javascript

javascript copied to clipboard

adding jumpcut to the In The Wild section

2

julianjca11

array-callback-return example corrected in Readme.md for issue #1806

3

Fixes #1806

abhinavsharma629

ESLint is missing rules for blank lines after blocks (section 19.7)

16

[Section 19.7](https://github.com/airbnb/javascript#whitespace--after-blocks) requires a blank line after blocks and before the next statement. This uses JSCS [requirePaddingNewLinesAfterBlocks](http://jscs.info/rule/requirePaddingNewLinesAfterBlocks) but the equivalent [padding-line-between-statements](https://eslint.org/docs/rules/padding-line-between-statements) is missing from the base ESLint config. I believe...

jfrej

Shown Example Is Not Appropriate for arrays--callback-return

2

[4.6 in Readme](https://github.com/airbnb/javascript#arrays--callback-return) last example is shown as ``` inbox.filter((msg) => { const { subject, author } = msg; if (subject === 'Mockingbird') { return author === 'Harper Lee'; }...

praveeno

Documentation: react/jsx-filename-extension can break checks without --ext arguments

1

Adding the `react/jsx-filename-extension` is just fine as a rule, but adding some direction that you will need to add the `--ext=js --ext=jsx` arguments to the eslint cli for it to...

bassettsj

Please include the "Why" in your styleguide

14

Hi there As your styleguide is getting popular I just wanted to express some concerns I have with it. I'm generally for styleguides, however, I believe that things are always...

gionkunz

Arrow function should not use as props in Onclick event

5

I have below 3 suggestion to this on JSX onClick Events - 1. Actually, we don't need to use .bind() or Arrow function in our code. You can simple use...

reetesha

Link to the translation of the React Style Guide in German.

asattelmaier

Document best practices for test assertions

4

There's an issue on enzyme https://github.com/airbnb/enzyme/issues/97 about strengthening the assertion styles to avoid false positives: > A great first task would be removing this rule override, and fixing our tests...

zeke

Best practice for wrapping function arguments

11

Style guide should advise wrapping function arguments that go over maximum line length. ``` js function someVeryLongFunctionName(someVeryLongArgumentName1, someVeryLongArgumentName2, someVeryLongArgumentName3) { // Function body } ``` or: ``` js function myFunction(someArg1,...

logashoff