javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Published 20 hours ago • verified publisher icon airbnb

Added max-len rule

Open screendriver opened this issue 8 years ago • 8 comments

Closes #509

screendriver avatar Sep 16 '15 07:09 screendriver

I think according to https://github.com/airbnb/javascript#6.2 our max-length is 100 characters, not 80 characters. Please make the length explicit. I thought that this number was already well-declared and obvious in our styleguide, but I think I was thinking of our Ruby styleguide (length guidance here: https://github.com/airbnb/ruby#line-length).

Sorry to change direction so fast; I think we should wait for more discussion on the topic before merging this.

justjake avatar Sep 16 '15 08:09 justjake

Ok. I am fine with 100 characters as well. Should I modify this pull request or should we wait for others to discuss this whole thing?

screendriver avatar Sep 16 '15 08:09 screendriver

Go ahead and make it explicitly 100 chars in your markdown update and in the eslintrc. We'll let the PR sit here for a day or two after that and then I'll merge after consensus/people forget

justjake avatar Sep 16 '15 09:09 justjake

Done :sunglasses:

screendriver avatar Sep 16 '15 09:09 screendriver

Should I take the description really in the whitespace section? I think it has nothing to do with whitespaces.

screendriver avatar Sep 17 '15 05:09 screendriver

+1 I would like to see this merged.

brianpeiris avatar Oct 23 '15 20:10 brianpeiris

oops

justjake avatar Nov 05 '15 23:11 justjake

@screendriver if you'd like to rebase this on top of master, we can now add and renumber sections without breaking existing links.

ljharb avatar Apr 03 '16 01:04 ljharb