javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Support flat config for `eslint-config-airbnb-base`

Open tamiroh opened this issue 1 year ago • 14 comments

This pull request supports flat config for eslint-config-airbnb-base.

An example of usage is as follows.

// eslint.config.mjs

import airbnbBase from "eslint-config-airbnb-base/flat";

export default [
  ...airbnbBase,
  // Add your own configs
];

tamiroh avatar Nov 12 '24 13:11 tamiroh

Is this pull request fully functional? only approval is missing?

mcorbelli avatar Jan 02 '25 07:01 mcorbelli

@mcorbelli no, it’s not functional until eslint-find-rules is updated.

ljharb avatar Jan 02 '25 17:01 ljharb

@ljharb FYI: eslint-find-rules does have flat-config support now: https://github.com/sarbbottam/eslint-find-rules/releases/tag/v4.2.0

KonRatt avatar Jan 22 '25 15:01 KonRatt

Thanks, I’m aware since I’m the one who published it :-)

ljharb avatar Jan 22 '25 16:01 ljharb

Any update on when we're planning to get this in?

cdbattags avatar Mar 12 '25 17:03 cdbattags

@ljharb Hello! 👋 Is there anything else I can do to help get this pull request merged?

tamiroh avatar Mar 23 '25 12:03 tamiroh

Hello everyone. Looking at the timeline, the changes were approved 4 days ago. Does this mean that we will soon have a release compatible with eslint version 9?

Aluisio avatar Apr 03 '25 18:04 Aluisio

Hello everyone. Looking at the timeline, the changes were approved 4 days ago. Does this mean that we will soon have a release compatible with eslint version 9?

This repo's settings seem to allow for anyone to send an "approved" review. The PR still won't be mergeable without sufficient approval from the repo maintainers, and the approval 4 days ago wasn't from one of them.

mao-sz avatar Apr 03 '25 18:04 mao-sz

@tamiroh, Looks like there's some rebasing issues.

chrstrock avatar Apr 21 '25 13:04 chrstrock

@ljharb Can we prioritize this ? And get this merged. Thanks.

torachitj avatar Apr 22 '25 16:04 torachitj

I added a PR that is this rebased from master: https://github.com/airbnb/javascript/pull/3123

chrstrock avatar May 02 '25 15:05 chrstrock

Please don't do that.

I can rebase this PR any time I like; rebasing isn't what's delaying this PR, my availability is.

ljharb avatar May 02 '25 16:05 ljharb

@ljharb I've been following and I know about your commitments, tasks and responsibilities with the community, but do you have any idea when support for version 9 will be available? I'm just asking because we really need support for version 9. There are many libs that depend on Airbnb.

whydea avatar Jun 05 '25 17:06 whydea

Hi @ljharb, I hope you're doing well. Can we still hope that when you have some time, you'll help with compatibility with v9?

Aluisio avatar Aug 12 '25 02:08 Aluisio