javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Documentation for 'import/no-extraneous-dependencies' is missing

Open cseas opened this issue 2 years ago • 13 comments

The rule is set to error in the config: https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js#L71

But there's no mention of it in the guide: https://github.com/airbnb/javascript/blob/master/README.md

This rule should be mentioned under the Modules section.

cseas avatar Feb 14 '23 09:02 cseas

Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

ljharb avatar Feb 14 '23 19:02 ljharb

Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

I didn't find link related to this rule on eslint

MohitBansal321 avatar Feb 22 '23 09:02 MohitBansal321

It's part of eslint-plugin-import.

ljharb avatar Feb 22 '23 17:02 ljharb

It's part of eslint-plugin-import.

Link (this one?) on which part of the modules should be added?

MohitBansal321 avatar Feb 23 '23 05:02 MohitBansal321

Yep, that's the rule.

I guess as a new section at the end of Modules?

ljharb avatar Feb 23 '23 06:02 ljharb

I have a PR up. Please take a look.

meddy672 avatar Mar 23 '23 16:03 meddy672

Could you please let me know if this issue is still open for contributions? If so, I would be very interested in working on it. Thank you!

Vivek-04022001 avatar Mar 24 '23 18:03 Vivek-04022001

@Vivek-04022001 no, the comment directly above yours links to a PR.

ljharb avatar Mar 24 '23 18:03 ljharb

Hi is this issue still open

utkarsh-shrivastav77 avatar May 15 '23 17:05 utkarsh-shrivastav77

@utkarsh-shrivastav77 yes, but it has a PR open.

ljharb avatar May 15 '23 17:05 ljharb

hi @cseas i can solve this issue please assign me

cyberwarrior-20 avatar Jul 30 '23 11:07 cyberwarrior-20

My .50 cents? Why is it something should be made a code style pattern if it can directly affect bundle sizes for ES modules?

angeloreale avatar Apr 18 '24 14:04 angeloreale

Everything can affect that, and that’s just not a rubric anyone should be applying to how your code is written.

ljharb avatar Apr 18 '24 14:04 ljharb