javascript icon indicating copy to clipboard operation
javascript copied to clipboard

[chore] Remove country flags for translation list

Open lizheming opened this issue 2 years ago • 11 comments

It doesn't suitable that add a country flags near by language name. Because a language may be used by many of countries.

lizheming avatar Sep 14 '22 05:09 lizheming

That's a reasonable take, but it's visually nice to have icons to identify them, and flags are the closest thing to a language icon we have.

Do you have a better suggestion?

ljharb avatar Sep 14 '22 05:09 ljharb

@ljharb I think there has no icon can represent a language name. But let we think about it another way, why we need a nice icon for a translation list? If we have no applicable to express them, why not remove them? At last, I think the right infomation is more important than nice style for a standard repo.

ps. Let we look at wikipedia, it also hasn't language icon at language list.

image

lizheming avatar Sep 14 '22 05:09 lizheming

I'm not sure I find that convincing.

What's the downside to having the flags here?

ljharb avatar Sep 14 '22 05:09 ljharb

@ljharb For example, both South Korea and North Korea are use Korea language, but their country flags are difference. Same situation like Germany and Austria both use german language, Argentina and Mexico and Spain both use Spanish language. It's not suitable to use one country flag represent language name.

lizheming avatar Sep 14 '22 06:09 lizheming

Sounds like an argument to include multiple country flags rather than just removing them?

ljharb avatar Sep 14 '22 06:09 ljharb

@ljharb every national language may have different count countries, I think both country flags added to list may misaligned. So I think remove them is better than add all of country flags.

lizheming avatar Sep 14 '22 06:09 lizheming

True. The list could instead be turned into a table, though, which would address that problem without having to remove any flags.

ljharb avatar Sep 14 '22 06:09 ljharb

@ljharb I can't agree with table solution. The main purpose for translation list just a link that we can go to translation repo, It's not emphasis for our repo. Is it too heavy for us that a table which has both countries flags?

lizheming avatar Sep 14 '22 06:09 lizheming

That purpose is served by providing a visual cue so readers can quickly find the language they're looking for in the list.

ljharb avatar Sep 14 '22 06:09 ljharb

@ljharb A language list is enough to visualize to user find target. I think more and more flag icons would make user dazzling. If you still decide to use table, I still respect it~

lizheming avatar Sep 14 '22 07:09 lizheming

I think the only change that makes sense here is adding any missing flags, and converting to a table so alignment is preserved.

ljharb avatar Sep 14 '22 15:09 ljharb