javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Add section about Short Circuit Evaluation

Open vitorlopez opened this issue 11 years ago • 7 comments

Add section about Short Circuit Evaluation

vitorlopez avatar Aug 18 '14 21:08 vitorlopez

Once @goatslacker's comments are addressed, this LGTM.

hshoff avatar Feb 27 '15 19:02 hshoff

@vlopez5 this is great - abusing value selection operators for control flow is bad news bears indeed. Are you still interested in landing this? It'd be great if you could rebase on latest master and address the comments in the PR :-)

ljharb avatar Dec 23 '15 19:12 ljharb

Please merge this in! :(

schinsue avatar Apr 24 '18 08:04 schinsue

@schinsue it's waiting on https://github.com/airbnb/javascript/pull/188#issuecomment-166979277 and/or the original PR author checking the "allow edits" box on the right side of the PR.

ljharb avatar Apr 24 '18 19:04 ljharb

@ljharb Am I allowed to create a fork and follow up on the comments made in the original PR?

EDIT: Maybe this can be closed, as chapter 17.2 Also addresses this.

schinsue avatar Apr 24 '18 19:04 schinsue

I'm sorry for the delay guys... I already checked the box to allow edits! Thanks guys!

vitorlopez avatar Apr 24 '18 19:04 vitorlopez

I've rebased this; but indeed, https://github.com/airbnb/javascript#control-statements--value-selection seems to already cover it (#1729)

ljharb avatar Apr 24 '18 22:04 ljharb