hypernova icon indicating copy to clipboard operation
hypernova copied to clipboard

Flex all the things

Open alexindigo opened this issue 8 years ago • 15 comments

Trying to make it more developer friendly.

The main change is to split worker's one big thing into separate methods, to allow downstream apps have hypernova's functionality on different endpoints and/or namespacing (e.g. components vs containers or different versions for backwards compatibility), while preserving original API.

Please let me know if anything else should be done/improved.

Thank you.

alexindigo avatar Jun 28 '16 00:06 alexindigo

I'll probably cherry-pick some commits from here and ship them in the 1.x branch

goatslacker avatar Jun 28 '16 04:06 goatslacker

@goatslacker Yep that was wrong branch. Updated.

alexindigo avatar Jun 28 '16 04:06 alexindigo

Looks like I missed stuff on my rush to commit. Added pre-commit to prevent such things.

alexindigo avatar Jun 28 '16 04:06 alexindigo

@goatslacker What are the commits you're not happy with? Thank you.

alexindigo avatar Jun 28 '16 04:06 alexindigo

Still looking into this. Haven't forgotten about this PR :)

goatslacker avatar Jun 30 '16 19:06 goatslacker

👍

alexindigo avatar Jun 30 '16 20:06 alexindigo

Ok so I've merged most of this here 6fd1f905e03bd2fd8d830c36e362d9ec0735405c

All that is remaining is the change of devMode -> clustering.

goatslacker avatar Jul 18 '16 22:07 goatslacker

Lets get this merged in. I think all we need is a better name other than clustering.

How about enableCluster? We can set the default to false and document this.

If you want to rebase/rename I can merge this in when ready.

It'll be a major change so I'll couple it with the other PR that has a breaking change.

goatslacker avatar Jul 18 '16 22:07 goatslacker

@goatslacker Thanks. I rebased and renamed All The Things :)

alexindigo avatar Jul 19 '16 07:07 alexindigo

@goatslacker do you mind to release that minor version? Thank you.

alexindigo avatar Jul 20 '16 02:07 alexindigo

I'll release it tomorrow. I have to prep a changelog :)

goatslacker avatar Jul 20 '16 04:07 goatslacker

@goatslacker Cool, thanks.

alexindigo avatar Jul 20 '16 06:07 alexindigo

@goatslacker Hey, any news on the release front? :) Thank you.

alexindigo avatar Jul 21 '16 18:07 alexindigo

[email protected] is on npm

goatslacker avatar Jul 21 '16 19:07 goatslacker

Cool. Thanks a lot!

alexindigo avatar Jul 21 '16 21:07 alexindigo