hypernova
hypernova copied to clipboard
fix README
I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?
I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?
resubmitting https://github.com/airbnb/hypernova/pull/169/files
@ljharb should we just remove v4 and v5 tests? seems it doesn't support destructuring and introduce 'unexpected token ...' error
No, first we should fix them. We should be able to use any syntax if we have Babel set up right.
Please don’t “resubmit” PRs; old ones can and should be reused. Every PR is a permanent ref on the repo, and creating duplicates just pollutes things.
I think maybe updating the Airbnb preset is probably a better bet
I think maybe updating the Airbnb preset is probably a better bet
OK. But after adding the plugin, it's working on my local with node v5, not sure why the test is still failing in github
@ljharb is the babel version setup in uses: ljharb/actions/.github/workflows/node.yml@main
? not sure how to proceed
if this is left open, then someone else can pick it up.