hypernova icon indicating copy to clipboard operation
hypernova copied to clipboard

fix README

Open duoertai opened this issue 2 years ago • 9 comments

duoertai avatar May 14 '22 21:05 duoertai

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

ljharb avatar May 14 '22 21:05 ljharb

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

resubmitting https://github.com/airbnb/hypernova/pull/169/files

duoertai avatar May 14 '22 21:05 duoertai

@ljharb should we just remove v4 and v5 tests? seems it doesn't support destructuring and introduce 'unexpected token ...' error

duoertai avatar May 14 '22 21:05 duoertai

No, first we should fix them. We should be able to use any syntax if we have Babel set up right.

ljharb avatar May 14 '22 21:05 ljharb

Please don’t “resubmit” PRs; old ones can and should be reused. Every PR is a permanent ref on the repo, and creating duplicates just pollutes things.

ljharb avatar May 14 '22 21:05 ljharb

I think maybe updating the Airbnb preset is probably a better bet

ljharb avatar May 14 '22 22:05 ljharb

I think maybe updating the Airbnb preset is probably a better bet

OK. But after adding the plugin, it's working on my local with node v5, not sure why the test is still failing in github

duoertai avatar May 14 '22 22:05 duoertai

@ljharb is the babel version setup in uses: ljharb/actions/.github/workflows/node.yml@main ? not sure how to proceed

duoertai avatar May 14 '22 23:05 duoertai

if this is left open, then someone else can pick it up.

ljharb avatar Feb 16 '23 23:02 ljharb