hypernova-ruby icon indicating copy to clipboard operation
hypernova-ruby copied to clipboard

Update to Faraday 1.0

Open 9toon opened this issue 3 years ago • 11 comments

As the PR #27 I sent a before, Migrating Faraday to 1.x has significant changes. So, I suggest to update the old dependencies and the supported Ruby versions in order to meet the recent development circumstances.

I think this gem is great, but it blocks updating the other gems which dependent to Faraday in my projects.

This change needs a major update, would you consider it?

ref: https://github.com/lostisland/faraday/blob/master/UPGRADING.md

9toon avatar Feb 28 '21 06:02 9toon

My project also requires faraday > 1.0. Any chance this could get a version cut?

ehlertij avatar Jun 16 '21 19:06 ehlertij

Dear @airbnb developers! Is there a slim chance that this PR will be merged anytime soon? Since it is difficult to determine who of the contributors is still working in AirBnb, I mention a few people. @goatslacker @100 @a15n @indiesquidge @keeleysam @lencioni @tobymao

Sorry for the shout, but this PR has been waiting for over a year without any answer. It will be nice of you if something moves on this matter. If you need help, let me know too. Thank you in advance.

torrocus avatar Jul 06 '22 10:07 torrocus

image

henriquesml avatar Aug 12 '22 19:08 henriquesml

up

voigtito avatar Aug 12 '22 20:08 voigtito

up

jvitormichels avatar Aug 12 '22 20:08 jvitormichels

I doesn't really know what it is, but I'm going to approve it because they asked for approval

erik-tomelin avatar Aug 12 '22 21:08 erik-tomelin

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

ljharb avatar Aug 12 '22 22:08 ljharb

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

@ljharb You are right, it's not a commendable behavior. I'm concerned that this project has been abandoned, even though many people are still using it. Lack of any information from the owners is perhaps the worst possible thing. What can we do to help?

torrocus avatar Aug 15 '22 21:08 torrocus

I doubt there’s anything to be done but wait patiently.

ljharb avatar Aug 15 '22 21:08 ljharb

I doubt there’s anything to be done but wait patiently.

@ljharb May I kindly ask what amount of patience is needed for some @airbnb developer to merge these changes? I would like to point out that this is over a year and a half. This project looks abandoned.

torrocus avatar Sep 07 '22 06:09 torrocus

LGTM, let's go for merge!

diclophis avatar Dec 09 '22 00:12 diclophis