chronon icon indicating copy to clipboard operation
chronon copied to clipboard

Published 20 hours ago • verified publisher icon airbnb

Enable logging levels, driven by log4j config

Open krisnaru opened this issue 9 months ago • 4 comments

Summary

This PR enables the logging, logging levels can be set from log4j conf

Why / Goal

Users should be able to drive config for which they want

Reviewers

@hzding621 @caiocamatta-stripe @nikhil-zlai

krisnaru avatar Feb 26 '25 07:02 krisnaru

This will spam our logging.

@pengyu-hou hardcoding log4j level inside code is anti pattern, it should be driven by log4j properties. I would suggest airbnb to fix your deployment pipelines to pass the log4j properties while submitting spark jobs to EMR clusters.

lakshmanayenduri avatar Apr 11 '25 05:04 lakshmanayenduri

This will spam our logging.

@pengyu-hou hardcoding log4j level inside code is anti pattern, it should be driven by log4j properties. I would suggest airbnb to fix your deployment pipelines to pass the log4j properties while submitting spark jobs to EMR clusters.

Thanks Laxman for review. let me work with pengyu and push this MR

krisnaru avatar May 01 '25 05:05 krisnaru

Thanks @krisnaru . I will spend sometime on it and test it from our end.

pengyu-hou avatar May 01 '25 16:05 pengyu-hou

@divyamanohar-stripe it is this PR.

pengyu-hou avatar May 13 '25 19:05 pengyu-hou

https://chatgpt.com/share/683743ff-4918-800a-8cf3-45de90eec468 is an example on how to pass log4j.properties via dependency injection

knarukulla avatar May 28 '25 17:05 knarukulla