chronon icon indicating copy to clipboard operation
chronon copied to clipboard

Don't request null keys from KVStore

Open jbrooks-stripe opened this issue 8 months ago • 1 comments

Summary

Updates the Fetcher to not include or attempt any requests when the keys are null.

Why / Goal

KVStore implementations are left up to consumers. In the case where null entries are being written out, this can lead to online/offline consistency issues. The GroupByUpload jobs are all setup to filter out any null keys, but the KVStore will still attempt to pull values if they exist. This adds parity with the null checks done in the GroupByUpload jobs to the online path and will exclude any attempt to pull values for null keys.

Test Plan

  • [x] Added Unit Tests
  • [x] Covered by existing CI
  • [ ] Integration tested

Checklist

  • [ ] Documentation update

Reviewers

jbrooks-stripe avatar Jun 14 '24 17:06 jbrooks-stripe