binaryalert icon indicating copy to clipboard operation
binaryalert copied to clipboard

Py deps upgrade, TF upgrade, TF fixes

Open phretor opened this issue 4 years ago • 1 comments

to: @airbnb/binaryalert-maintainers

resolves #145 resolves #173 resolves #167 resolves #166 resolves #154 resolves #153 resolves #152 resolves #142 resolves #144

Background

I see that there are many pending PR and open issues, so I tried to take the most important into account into one, comprehensive PR.

Changes

  • TF upgrade to latest version 0.14.5
  • Python deps upgrades (at some point I suggest to migrate to Poetry as opposed to PIP)
  • Added TF variable aws_account_name to solve #145
  • Changed /usr/bin/env python3 into /usr/bin/env python to be venv friendly (Py3 should be the default)

Testing

python manage.py unit_test

phretor avatar Jan 27 '21 12:01 phretor

I checked the logs of the CI job but I can't see any meaningful error message. I see that both jobs on Py 3.6 and Py 3.7 have errored, but I can't see the cause. Maybe you have some hints on how to dig deeper @ryandeivert ? Thanks!

phretor avatar Jan 28 '21 09:01 phretor