binaryalert icon indicating copy to clipboard operation
binaryalert copied to clipboard

Fixed cve_rules folder name according to latest Yara-Rule repo structure

Open sunilrebel opened this issue 5 years ago • 3 comments

to: @airbnb/binaryalert-maintainers cc: size: small|medium|large resolves #

Background

Yara rules were not fetched from the defined folder because the repo structure changed and folder were renamed.

Changes

  • fixed the folder name according to current structure

Testing

Tested on my local system. Screenshot attached.

image

sunilrebel avatar Mar 31 '20 13:03 sunilrebel

Coverage Status

Coverage remained the same at 90.52% when pulling 8f2bbb0d3010f546557549a175be2e9cbcef9b98 on sunilrebel:master into a9c0f06affc35e1f8e45bb77f835b92350c68a0b on airbnb:master.

coveralls avatar Mar 31 '20 13:03 coveralls

What I have to do to increase the coverage? It is a folder name change which is used while cloning rules

sunilrebel avatar Apr 01 '20 16:04 sunilrebel

Any chance this can get merged? New builds of the project are missing out on these yara rules.

jdheyburn avatar Aug 27 '20 11:08 jdheyburn