babel-plugin-inline-react-svg icon indicating copy to clipboard operation
babel-plugin-inline-react-svg copied to clipboard

migrate from travis to github actions

Open akellbl4 opened this issue 3 years ago • 4 comments
trafficstars

Implements CI jobs with Github Actions Passed actions on my fork

akellbl4 avatar Sep 14 '22 02:09 akellbl4

@akellbl4 the only other thing this needs is the "restricted branches" setting changed to no longer require travis, which requires an @airbnb employee to change.

Once this lands, the actions will run, after which the restricted branch settings can add the actions it should thenceforth require.

ljharb avatar Sep 14 '22 03:09 ljharb

Rebased; this is now good to go. No need for further changes until an admin is able to fix the protected branch settings, at which point i'll merge this :-)

ljharb avatar Sep 14 '22 04:09 ljharb

Hey @ljharb, how can we ping anyone from @airbnb to take a look on it? :)

akellbl4 avatar Sep 16 '22 15:09 akellbl4

I’ve already done so; all we can do now is wait.

ljharb avatar Sep 16 '22 16:09 ljharb

@ljharb I've added some of the new checks as required in the branch restriction settings, but I seem to be missing a node one that we've done elsewhere.

image

Do you happen to know what I should be searching for here? Is it posttest?

lencioni avatar Feb 16 '23 15:02 lencioni

@lencioni there should be posttest, as well as two node ones, but they won't show up in the autocomplete unless they've run recently, and this PR ran months ago :-) the merge into master, however, will populate the dropdown soon so you can add them.

ljharb avatar Feb 16 '23 17:02 ljharb

The node ones are not showing up. I had done #119 in hopes that it would trigger it, but it seems to not have. In any case, I added posttest now.

lencioni avatar Feb 16 '23 22:02 lencioni

ah, try "latest majors"

ljharb avatar Feb 16 '23 23:02 ljharb

That gives me a check for each version, unfortunately image

lencioni avatar Feb 17 '23 15:02 lencioni

hm, you're right. i'll make a PR to fix it.

ljharb avatar Feb 17 '23 16:02 ljharb

#120

ljharb avatar Feb 17 '23 16:02 ljharb

Thanks! I added that one to the settings now, so I think we can call this a wrap

lencioni avatar Feb 17 '23 17:02 lencioni

@lencioni one more thing :-) can we remove the review requirement? i need to be able to push things without a PR to release properly.

ljharb avatar Feb 18 '23 00:02 ljharb

@ljharb agreed, that is super annoying for releasing. I think I've updated the settings now.

lencioni avatar Feb 21 '23 14:02 lencioni

Thanks! The only thing left is that the automatic rebase and allow edits checks only run on a PR :-/ so either we can make those optional, or, add me to the airbnb org with a custom role that allows me to bypass branch protections (which i assume is a bit more difficult, bureaucratically)

ljharb avatar Feb 21 '23 18:02 ljharb

I have made those optional now too. I think that's fine since making them required is unlikely to matter all that much anyway.

lencioni avatar Feb 21 '23 19:02 lencioni

Much obliged, and I agree.

ljharb avatar Feb 21 '23 19:02 ljharb