babel-plugin-dynamic-import-node
babel-plugin-dynamic-import-node copied to clipboard
Updated to babel 7
This requires airbnb/babel-preset-airbnb#37 to work.
- Updated all
babel
dependencies - Fixed all test cases
- Removed testing for
babel-preset-es2015
since it's been deprecated in favor or@babel/preset-env
You might need to make a PR for babel-plugin-add-module-exports
as well, since it is a devDependency, and also seems to use Babel 6
ref: 59naga/babel-plugin-add-module-exports#65.
Will close #56
You might need to make a PR for babel-plugin-add-module-exports as well, since it is a devDependency, and also seems to use Babel 6
babel-plugin-add-module-exports
is actually not good to use. Import statements will now use .default
if it exists. See https://babeljs.io/docs/en/v7-migration-api#export-changes.
I forgot to remove it from the dependencies, but I did remove it from .babelrc
.
@ljharb Now that airbnb/babel-preset-airbnb#37 has been merged, is this ready too?
They haven't released the changes to npm quite yet.
I'll update this PR now.
@vikr01 i'm going to re-add add-module-exports, since .default
should still never be exposed to require
.
@ljharb Sure that’s fine. Just to note though, babel’s plugins now expose .default
when using require
.
Sure, but just because they're doing the wrong thing doesn't mean we should :-)
v2.2.0 is released, containing this commit which allows it to work on both babel 6 and 7.
I'm going to keep this PR and update it to become v3, which explicitly will only support babel 7.