airpal icon indicating copy to clipboard operation
airpal copied to clipboard

Support sqlite and postgresql

Open Downchuck opened this issue 9 years ago • 7 comments

The underlying JDBI library already supports these.

Downchuck avatar Apr 20 '15 21:04 Downchuck

Sorry for the delay in responding! Have you tried just changing the configuration to see if it works? You would probably also have to include the jar on the classpath, but other than that I suspect it would just work.

andykram avatar May 12 '15 23:05 andykram

I think there's an issue in this line of code, with the string "mysql" hard-coded: https://github.com/airbnb/airpal/blob/40fc002d96b98ac683879ea9d3d9197acab46f27/src/main/java/com/airbnb/airpal/modules/AirpalModule.java#L116

Mainly though, I agree, it should (mostly) just work.

-Charles

Downchuck avatar May 13 '15 00:05 Downchuck

Ah, good call. I'll add making this configurable to the todo list.

andykram avatar May 13 '15 01:05 andykram

does this fixed?

wanghaisheng avatar Aug 03 '15 09:08 wanghaisheng

+1

mattdanna avatar Dec 22 '15 03:12 mattdanna

@andykram do you have any update on this request?

patriciorocca avatar Feb 03 '16 20:02 patriciorocca

I just merged https://github.com/airbnb/airpal/pull/152 which adds support for h2. PRs to support postgres, sqlite or other DBs are welcome.

andykram avatar Feb 04 '16 05:02 andykram