airbnb
KSP2 / Room 2.7 support
A lot of the work done here is based on changes made in this CL.
I've also had to upgrade a few libraries for K2 compatibility.
@oheyadam The Paparazzi file renames are most likely due to the change in the sorting logic? but would be nice if you can confirm it. That and adding the sorting logic to the processing of other annotations would be the only thing that I think we'd need to add. Thank you for being an absolute legend and pushing through on this change completely independently. I'm grateful for your contribution and you will be helping a lot of others 🎖️
Is there anything that still needs to be done? It seems the pipeline has failed more than a month ago.
@vinaygaba @oheyadam Hello guys, when do you expect this PR will hit production? I'm currently unable to update the Kotlin version to 2.1.x in my project because of this. I created an issue: https://github.com/airbnb/Showkase/issues/400, and then found this PR. I believe it will solve my issue as well. Please make it available as soon as possible 🙏
Also blocked by this and had to disable Showkase for the time being 😅 Is there anything that we can help to move this PR forward? 🙇
This looks like a really cool tool, but unfortunately, I'm unable to use it in my project due to this issue. Do you know when this issue will be resolved and merged with master?
I was able to finally figure out why some of the tests were failing. One breaking change that I'll also add in the release notes is when a custom multi preview annotation is referenced from a different module than where the composable previews are declared. It feels like something changed in the KSP processing logic so if anyone here can help me point to it, that would be fantastic. This is the commit I made to co-locate the previews and custom annotation declaration - https://github.com/airbnb/Showkase/pull/405/commits/10d455d89a73f01da1254f7b2c7b8d0f0dce4efd. Ideally this move wasn't needed (like before).
Anyway, I think we should be unblocked for now and I'll do a release shortly 🎉
Thank you @oheyadam for doing the heavy lifting here and contributing to Showkase. God's work!!! 🙏🏻
Support for K2/KSP2 is now available in the latest release - https://github.com/airbnb/Showkase/releases/tag/1.0.5