Showkase icon indicating copy to clipboard operation
Showkase copied to clipboard

ShowkaseBrowserActivity does not open Components/Colors/Typography

Open dostalleos opened this issue 1 year ago • 6 comments

I'm using Showkase.getBrowserIntent(context) to start the browser activity with my previews. It starts and shows the options (Components, Colors, and Typography) correctly.

But if click on any option, only the AppBar changes its title, but the content stays the same. Please check the screenshots below.

It used to work without any issues. Unfortunately, I don't know when it started. I think that it's not caused by any Showkase SDK update. I suspect Compose SDK.

Showkase version: 1.0.0-beta18 Compose version: 1.4.0

image image image

dostalleos avatar Apr 04 '23 12:04 dostalleos

Hi, thanks for the report! Is this maybe the same issue as this? https://github.com/airbnb/Showkase/issues/310

oas004 avatar Apr 04 '23 13:04 oas004

Yeah, it looks similar. But I'm not experiencing any crashes.

I'm using the following dependencies (latest stable versions): Compose navigation v2.5.3 Accompanist Navigation v0.30.0

It works with Accompanist Navigation v0.28.0.

Are you planning to update the SDK to work with the latest stable versions?

dostalleos avatar Apr 04 '23 15:04 dostalleos

Hm, It looked very similar at least 🤔

For updating, I think we should bump some of the versions. Maybe we should configure renovate to do it more effortlessly :) Wdyt @vinaygaba ? :)

oas004 avatar Apr 04 '23 17:04 oas004

It works again with accompanist navigation v0.30.1.

dostalleos avatar Apr 11 '23 11:04 dostalleos

It works again with accompanist navigation v0.30.1.

For me, this didn't work. @oas004 Any other suggestions?

SohelMNumerator avatar Jul 21 '23 20:07 SohelMNumerator

Experiencing same behaviour

joselamar avatar Jul 26 '23 16:07 joselamar