DeepLinkDispatch icon indicating copy to clipboard operation
DeepLinkDispatch copied to clipboard

DeepLinkProcessor overrides previous intent flags

Open danilolapegna opened this issue 6 years ago • 1 comments

I can see that the DeepLinkProcessor file has in its code, line 527:

.addStatement("newIntent.setFlags(Intent.FLAG_ACTIVITY_FORWARD_RESULT)")

Shouldn't it be "addFlags" instead of "setFlags"? The setFlags overrides any other flag I could have previously added to an intent created in @DeepLink annotated method (ex. Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_SINGLE_TOP, etc.) and this may cause navigation issues, or anyway override the navigation behaviour I've thought for a specific deep link (ex. I want an activity ran via deep link to start a new task and clear previous ones. Right now I can't).

Thanks

danilolapegna avatar Sep 13 '17 11:09 danilolapegna

This issue still occurs. Any news?

HarisHoulis avatar May 28 '20 16:05 HarisHoulis