BuckSample icon indicating copy to clipboard operation
BuckSample copied to clipboard

Published 20 hours ago • verified publisher icon airbnb

Move AFNetworking to binary cocoapod

Open thedavidharris opened this issue 6 years ago • 2 comments
trafficstars

Addresses https://github.com/airbnb/BuckSample/issues/74, might not want to vendor the pods folder in this approach

  • [x ] Built and ran in Xcode (make project)
  • [x ] Built and ran with Buck CLI (make debug)

Tests didn't seem to be working on my machine, everything runs fine, was concerned about tests mostly for the embedding.

thedavidharris avatar Sep 25 '19 03:09 thedavidharris

@thedavidharris Is there any code in the app that exercises this library? I'd love to make sure that there's a test that makes a network call with this binary library. Maybe https://swapi.co/ or something.

shepting avatar Oct 29 '19 17:10 shepting

Just https://github.com/airbnb/BuckSample/blob/0a4a4d2919b05ba74da4791def260174556a06c0/Libraries/SwiftWithPrecompiledDependency/Sources/SwiftWithPrecompiledDependencyClass.swift, if there's probably an easier lib that could get used without dipping into networking to check things are working

thedavidharris avatar Nov 03 '19 18:11 thedavidharris