AirMapView icon indicating copy to clipboard operation
AirMapView copied to clipboard

Supply permission callback

Open skywalkerDavid opened this issue 8 years ago • 4 comments

Descriptions:

Supply the permission callbacks.

  1. Supply the denied and neverAskAgain callback
  2. Supply onCheckLocationPermissionResult, since onRequestPermissionsResult in NativeGoogleMapFragment and WebviewMapFragment won't be called when requestPermissions.

Test:

Tested with Sample app

Reviewers:

@felipecsl @gpeal @nwadams

skywalkerDavid avatar Oct 31 '17 05:10 skywalkerDavid

Is this the fix for #112?

felipecsl avatar Oct 31 '17 19:10 felipecsl

@felipecsl yes, it fixes the #112 and 1 other issue about permission: setMyLocationEnabled won't work immediately even after the permission is accepted.

Thank you for the comments, they are all very good, I will address them soon.

skywalkerDavid avatar Nov 01 '17 02:11 skywalkerDavid

Comments addressed.

skywalkerDavid avatar Nov 01 '17 05:11 skywalkerDavid

@felipecsl PTAL, thank you

skywalkerDavid avatar Nov 06 '17 01:11 skywalkerDavid