Andy Stewart comments

Results 145 comments of


                                            Andy Stewart

rooter_patterns child directories not working as expected

Looking at the code, I now remember that a rooter pattern is supposed to be a directory name, not a full path – unless it is a (relative) glob. @cdalsass...

rooter_patterns child directories not working as expected

I've never actually had this problem in practice. I always just treat the git repo I'm in as the root. The solution would be to change the code to accept...

Fix destroy of has_one with multiple belongs_to

@Edouard-chin All the tests are passing now. Ready for you to look at again.

Fix destroy of has_one with multiple belongs_to

@Edouard-chin Thanks for reviewing! Presumably I should combine all the commits into a single commit and rewrite the commit message?

Fix destroy of has_one with multiple belongs_to

All done! Thanks for all the guidance :-)

Fix destroy of has_one with multiple belongs_to

The build failure is due to unrelated test failures in ActiveStorage.

Fix destroy of has_one with multiple belongs_to

> Someone from the core team will give this the final merge when they get a chance. @Edouard-chin Is there a way to get this noticed by the core team?

Fix destroy of has_one with multiple belongs_to

@skipkayhil Thank you.

Fix destroy of has_one with multiple belongs_to

I just rebased and re-pushed this. The test failure is entirely unrelated. @byroot Do you think it would be possible to slip this into 7.2.0?

Fix destroy of has_one with multiple belongs_to

@byroot Thank you very much!