aioquic icon indicating copy to clipboard operation
aioquic copied to clipboard

[connection] update path challenge according to the draft [JF & CC]

Open ElNiak opened this issue 3 years ago • 5 comments

" Path validation succeeds when a PATH_RESPONSE frame is received that contains the data that was sent in a previous PATH_CHALLENGE frame. A PATH_RESPONSE frame received on any network path validates the path on which the PATH_CHALLENGE was sent."

We try to modify the PATH_CHALLENGE part of the connection.py to follow this rule that we found with a testing tool Ivy. The problem before was that if the PATH_RESPONSE was received on a different path the challenge was considered as failed.

JF & CC

ElNiak avatar May 04 '21 19:05 ElNiak

This looks like a good catch. Would you mind cleaning up the patch (removing commented code and debug statements)?

jlaine avatar Jul 07 '21 10:07 jlaine

Hello @ElNiak any chance of getting the code into a shape I can merge it?

jlaine avatar Dec 31 '21 15:12 jlaine

Hello, sorry we forget about that it will be done asap !

ElNiak avatar Jan 02 '22 14:01 ElNiak

The PR seems to completely break the test suite would you mind updating it?

jlaine avatar Feb 02 '22 09:02 jlaine

Hi @ElNiak do you plan to complete the work on this PR?

jlaine avatar Jan 07 '24 13:01 jlaine

Closing this in favor of the approach of [#483].

rthalley avatar Mar 10 '24 23:03 rthalley