aioice icon indicating copy to clipboard operation
aioice copied to clipboard

Support the use of a static media port in a Connection

Open sirf opened this issue 1 year ago • 3 comments

This makes it possible to run inside a docker container without a STUN/TURN server.

The issue with a randomly assigned port is that all ports must be published in advance when the container ls launched,

sirf avatar Sep 22 '22 08:09 sirf

In most use-cases (e.g. WebRTC) there are going to be multiple connections, how is this going to work?

jlaine avatar Oct 16 '22 10:10 jlaine

In our use-case we do CPU/GPU intensive processing on the WebRTC media stream and need to scale the hardware infrastructure as the number of client grows, and we've decided to run one container per client hence the need to know which port to open beforehand. We're already running the proposed change and it works great.

That being said, the solution proposed in https://github.com/aiortc/aioice/issues/47 seems more flexible and will cater for our use-case as well.

sirf avatar Oct 16 '22 12:10 sirf

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (b24214d) compared to base (f08956b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1184      1184           
=========================================
  Hits          1184      1184           
Impacted Files Coverage Δ
src/aioice/ice.py 100.00% <100.00%> (ø)
src/aioice/turn.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 18 '22 07:10 codecov[bot]

This is a more flexible solution https://github.com/aiortc/aioice/pull/63

sirf avatar Oct 26 '22 13:10 sirf