wip: feat: implementing trickle ice

[rprata]

wip

[jlaine]

The CI errors look specific to your branch, I've re-run the tests on the main branch and I'm not getting errors. see https://github.com/jlaine/aioice/actions/runs/2205560373

I have to admit I don't see where this code is going. I was expecting something like gather() becoming an async iterator. Also the "hard" changes are going to concern candidate pairing: you can no longer count on having all your local candidates before you start adding remote candidates.

[rprata]

The CI errors look specific to your branch, I've re-run the tests on the main branch and I'm not getting errors. see https://github.com/jlaine/aioice/actions/runs/2205560373

Sorry, I made something wrong in my local environment.

I have to admit I don't see where this code is going. I was expecting something like gather() becoming an async iterator. Also the "hard" changes are going to concern candidate pairing: you can no longer count on having all your local candidates before you start adding remote candidates.

I thought at that moment refactor the function get_component_candidates and then find a way to use the gather for each element in local candidates step can be called concurrently and provide an intermediate local candidates list ASAP to send offer . Do you agree or you see another point?

[jlaine]

I still think you probably want an async iterator at the end of the day, so that we can yield the candidates as we collect them. That way API users can do:

async for candidate in conn.gather():
    do_something(candidate)

Obviously feel free to suggest a different API! I think taking a look at what other implementations are doing might be of value too before diving into the nitty-gritty work.

[codecov[bot]]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.25 :warning:

Comparison is base (fe817e6) 100.00% compared to head (15b2853) 99.75%.

Additional details and impacted files

@@             Coverage Diff             @@
##              main      #56      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files            7        7              
  Lines         1200     1213      +13     
===========================================
+ Hits          1200     1210      +10     
- Misses           0        3       +3     

Impacted Files	Coverage Δ
src/aioice/ice.py	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[abhinavsingh]

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(. Any hope on getting this PR in anytime soon guys. Thank you!!!

[jlaine]

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(. Any hope on getting this PR in anytime soon guys. Thank you!!!

Just to clarify, this PR doesn't implement trickle ICE, as it stands it just does some refactoring.

[rprata]

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(. Any hope on getting this PR in anytime soon guys. Thank you!!!

Just to clarify, this PR doesn't implement trickle ICE, as it stands it just does some refactoring.

Sorry @jlaine, but I can't continue this work now. Feel free to this ti close the PR.