yarl
yarl copied to clipboard
Inconsistent behaviour between Cython and CPython (or lack of docs, or both)
What do these changes do?
Adds a test for the quoting inconsistency that I believe needs change. It is written such that the compiled module passes but setting YARL_NO_EXTENSIONS=1
fails.
Submitting without the desired change to verify CI results. May or may not add actual content eventually.
Are there changes in behavior for the user?
No, but maybe there should be. Telling the user they are responsible about URL correctness is not particularly useful if the specific correctness properties are not enumerated.
Related issue number
Still roughly the same scenario, just moved from https://github.com/aio-libs/aiohttp/pull/8088 where it was unnecessarily tested for, and thus failed on PyPy
Checklist
- [ ] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
We should really finish up #860 to catch the differences better...
Codecov Report
Attention: Patch coverage is 0%
with 28 lines
in your changes missing coverage. Please review.
Project coverage is 61.84%. Comparing base (
0baa61a
) to head (753781a
).
Files | Patch % | Lines |
---|---|---|
tests/test_url_parsing.py | 0.00% | 28 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 61.96% 61.84% -0.13%
==========================================
Files 38 38
Lines 6510 6562 +52
Branches 353 353
==========================================
+ Hits 4034 4058 +24
- Misses 2448 2476 +28
Partials 28 28
Flag | Coverage Δ | |
---|---|---|
CI-GHA | 61.81% <0.00%> (-0.13%) |
:arrow_down: |
MyPy | 24.47% <0.00%> (-0.18%) |
:arrow_down: |
OS-Linux | 99.25% <ø> (+<0.01%) |
:arrow_up: |
OS-Windows | 99.58% <ø> (+<0.01%) |
:arrow_up: |
OS-macOS | 99.01% <ø> (+<0.01%) |
:arrow_up: |
Py-3.10.11 | 98.92% <ø> (+<0.01%) |
:arrow_up: |
Py-3.10.14 | 99.13% <ø> (+<0.01%) |
:arrow_up: |
Py-3.11.9 | 99.13% <ø> (+<0.01%) |
:arrow_up: |
Py-3.12.4 | 99.13% <ø> (+<0.01%) |
:arrow_up: |
Py-3.8.10 | 98.86% <ø> (+<0.01%) |
:arrow_up: |
Py-3.8.18 | 99.07% <ø> (+<0.01%) |
:arrow_up: |
Py-3.9.13 | 98.86% <ø> (+<0.01%) |
:arrow_up: |
Py-3.9.19 | 99.07% <ø> (+<0.01%) |
:arrow_up: |
Py-pypy7.3.11 | 94.71% <ø> (-4.68%) |
:arrow_down: |
Py-pypy7.3.16 | 94.35% <ø> (-5.06%) |
:arrow_down: |
VM-macos-latest | 99.01% <ø> (+<0.01%) |
:arrow_up: |
VM-ubuntu-latest | 99.25% <ø> (+<0.01%) |
:arrow_up: |
VM-windows-latest | 99.58% <ø> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.