yarl icon indicating copy to clipboard operation
yarl copied to clipboard

Update mypy, remove unused ignores and casts

Open hauntsaninja opened this issue 1 year ago • 1 comments

Are there changes in behavior for the user?

No

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes

hauntsaninja avatar Jul 02 '24 07:07 hauntsaninja

Looks like the 3.10 and 3.8 runs also need types-Pygments in their additional deps.

webknjaz avatar Jul 03 '24 20:07 webknjaz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.60%. Comparing base (f40adb0) to head (f64186e). Report is 352 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          38       38           
  Lines        6721     6721           
  Branches      368      368           
=======================================
  Hits         4208     4208           
  Misses       2486     2486           
  Partials       27       27           
Flag Coverage Δ
CI-GHA 62.57% <100.00%> (ø)
MyPy 25.92% <100.00%> (ø)
OS-Linux 99.26% <100.00%> (ø)
OS-Windows 99.59% <100.00%> (ø)
OS-macOS 99.03% <100.00%> (ø)
Py-3.10.11 98.94% <100.00%> (ø)
Py-3.10.14 99.15% <100.00%> (ø)
Py-3.11.9 99.15% <100.00%> (ø)
Py-3.12.5 99.15% <100.00%> (ø)
Py-3.13.0-rc.1 99.15% <100.00%> (ø)
Py-3.8.10 98.88% <100.00%> (ø)
Py-3.8.18 99.09% <100.00%> (ø)
Py-3.9.13 98.88% <100.00%> (ø)
Py-3.9.19 99.09% <100.00%> (ø)
Py-pypy7.3.11 99.40% <50.00%> (ø)
Py-pypy7.3.16 99.43% <50.00%> (ø)
VM-macos-latest 99.03% <100.00%> (ø)
VM-ubuntu-latest 99.26% <100.00%> (ø)
VM-windows-latest 99.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 30 '24 22:08 codecov[bot]

skip label added as a workaround since the bot is currently not working as expected

bdraco avatar Aug 30 '24 22:08 bdraco

mypy already got updated so I removed that

bdraco avatar Aug 30 '24 22:08 bdraco