async-timeout icon indicating copy to clipboard operation
async-timeout copied to clipboard

Add clean fix for cancelation on 3.9+.

Open Dreamsorcerer opened this issue 4 years ago • 4 comments
trafficstars

Dreamsorcerer avatar Sep 03 '21 19:09 Dreamsorcerer

Codecov Report

Merging #235 (dbec807) into master (97161bf) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          107       115    +8     
  Branches        16        18    +2     
=========================================
+ Hits           107       115    +8     
Flag Coverage Δ
unit 96.52% <85.71%> (-1.61%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
async_timeout/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97161bf...dbec807. Read the comment docs.

codecov[bot] avatar Sep 03 '21 19:09 codecov[bot]

@Dreamsorcerer do you want to resurrect this effort?

webknjaz avatar Feb 16 '24 16:02 webknjaz

Is it related to #295?

webknjaz avatar Feb 16 '24 16:02 webknjaz

@Dreamsorcerer do you want to resurrect this effort?

I will return to this in some form, and verify if the problem is actually fixed in asyncio.timeout() or not. But, this library itself should probably be deprecated (and archived once asyncio.timeout() is available in all supported versions of Python).

Is it related to #295?

Yes, I'm pretty sure that PR is incorrect, as explained in my comments.

Dreamsorcerer avatar Feb 16 '24 17:02 Dreamsorcerer