aiosmtpd
aiosmtpd copied to clipboard
Implement custom SSL handshake timeout on Controller
trafficstars
What do these changes do?
This implements a custom ssl_handshake_timeout parameter on Controllers that is then passed to the loop.create_server() and used in the smtp_STARTTLS methods to modify the amount of time that the server will wait for the SSL handshake to complete.
Are there changes in behavior for the user?
Related issue number
Closes #269
Checklist
- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] tox testenvs have been executed in the following environments:
- [ ] Linux (Ubuntu 18.04, Ubuntu 20.04, Arch):
{py36,py37,py38,py39}-{nocov,cov,diffcov}, qa, docs - [ ] Windows (7, 10):
{py36,py37,py38,py39}-{nocov,cov,diffcov} - [ ] WSL 1.0 (Ubuntu 18.04):
{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs - [ ] FreeBSD (12.2, 12.1, 11.4):
{py36,pypy3}-{nocov,cov,diffcov}, qa - [ ] Cygwin:
py36-{nocov,cov,diffcov}, qa, docs
- [ ] Linux (Ubuntu 18.04, Ubuntu 20.04, Arch):
- [x] Documentation reflects the changes
- [x] Add a news fragment into the
NEWS.rstfile- Add under the "aiosmtpd-next" section, creating one if necessary
- You may create subsections to group the changes, if you like
- Use full sentences with correct case and punctuation
- Refer to relevant Issue if applicable
- Add under the "aiosmtpd-next" section, creating one if necessary