aioodbc icon indicating copy to clipboard operation
aioodbc copied to clipboard

Connection pool is incompatible with Python 3.9 issue fix

Open HorusTheSonOfOsiris opened this issue 3 years ago • 8 comments

What do these changes do?

The await with keyword is no longer supported in python and has been replaced with async keyword. This release fixes the connection pool is incompatible error which was raised while making a connection request to sql server.

According to the official documentation, the asyncio.Condition object should be handled using an async with construct instead of a with with an await expression as done in aiodbc.

#294

HorusTheSonOfOsiris avatar Apr 06 '21 05:04 HorusTheSonOfOsiris

I have fixed the pool.py and code is working alright.

HorusTheSonOfOsiris avatar Apr 06 '21 05:04 HorusTheSonOfOsiris

:tada: Thank you!!!!

singlecheeze avatar Apr 07 '21 15:04 singlecheeze

Thank you very much, I just bumped into this problem. Someone accept this PR please!

ia-Simon avatar May 19 '21 18:05 ia-Simon

I've just bumped into this same issue. Please either accept this PR or edit the documentation so it's clear that the project does not support Python 3.9 atm.

andreheringer avatar Jul 22 '21 20:07 andreheringer

I'll just base my dependencies on this fork for now :P

Thank you very much for this fix, Horus, son of Osiris

apisarenco avatar Jan 11 '22 22:01 apisarenco

I'll just base my dependencies on this fork for now :P

Thank you very much for this fix, Horus, son of Osiris

All good, mate.

HorusTheSonOfOsiris avatar Jan 18 '22 21:01 HorusTheSonOfOsiris

Will this be merged sometime soon?

CoonCat21 avatar Jan 26 '22 16:01 CoonCat21

The original project seems abandoned. I doubt that you're gonna get any more changes.

Consider using a fork like this one instead, or do what I eventually did - write my own code, based on the old one, that does the minimum needed features, with thanks to original developers, and attribution to their work. I hope they're fine and healthy.

apisarenco avatar Jan 26 '22 16:01 apisarenco