aiomysql icon indicating copy to clipboard operation
aiomysql copied to clipboard

Add SA executemany compiled cache support

Open katajakasa opened this issue 6 years ago • 5 comments

Add compiled_cache support for SAConnection.executemany. Add tests for INSERT and UPDATE cases.

katajakasa avatar Jan 20 '19 20:01 katajakasa

Codecov Report

Merging #376 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   92.28%   92.32%   +0.03%     
==========================================
  Files           9        9              
  Lines        1180     1186       +6     
  Branches      172      174       +2     
==========================================
+ Hits         1089     1095       +6     
  Misses         64       64              
  Partials       27       27
Impacted Files Coverage Δ
aiomysql/sa/connection.py 93.53% <100%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66d8657...9183e27. Read the comment docs.

codecov[bot] avatar Jan 20 '19 20:01 codecov[bot]

Other than that list comprehension, it looks great :smile:

terricain avatar Jan 20 '19 23:01 terricain

Okay, so I dropped the extra checks. Turns out those were not actually needed plus they were a perf hit when adding larger amounts of rows. Also added a testcase for DELETE :)

katajakasa avatar Jan 21 '19 22:01 katajakasa

This good to go now?

terricain avatar May 01 '19 09:05 terricain

@terrycain Yes, this is good to go.

katajakasa avatar May 01 '19 12:05 katajakasa