aiomysql
aiomysql copied to clipboard
Release as 1.0.0
I'm using the library heavily in production. I think with the upgrade of pymysql (#251) this package is rock-solid, feature rich, and worthy of 1.0.0.
Good point. Plan could be following:
- Drop python < 3.5 support
- Use native coroutines instead of old ones
- Fix issue with multiple queries.
On Fri, Apr 20, 2018, 19:06 Terris Linenbach [email protected] wrote:
I'm using the library heavily in production. I think with the upgrade of pymysql (#251 https://github.com/aio-libs/aiomysql/issues/251) this package is rock-solid, feature rich, and worthy of 1.0.0.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aio-libs/aiomysql/issues/281, or mute the thread https://github.com/notifications/unsubscribe-auth/AANoZ3X3ZbgUhQf4Vdxg5PMVL7h8qPR6ks5tqgecgaJpZM4Tdt1T .
@jettify Could you describe point 3? What is the issue number? Also it would be helpful to create milestone for this.
I mean this one https://github.com/aio-libs/aiomysql/issues/251
I'm happy to PR point 1
I'm a happy user of aiopg. Getting to 1.0 for aiomysql is a significant milestone for asyncio that some may argue is long overdue. But at least it's within reach.
Started on point 2, which partially finishes point 1 too in #283, apologies in advanced for the nasty diff but it should serve as a decent starting point to rid the @asyncio.coroutine
#251 has another related bug .. you cant run a sql stmt with more than 6 or 7 statements. Aiomysql hangs.
Is this SSL related? :wink:
It might be as I discovered this yesterday with 0.0.14. I will dig into it. The underlying pymysql bug specific to #251 has been fixed but not released for some reason. Python is this weird community where critical packages are barely resourced. I get it - nobody is doing this for money. Again, that is weird but it works. Well, sort of.