aiojobs icon indicating copy to clipboard operation
aiojobs copied to clipboard

Fix scheduler hang when pending limit is reached

Open pollydrag opened this issue 5 years ago • 7 comments

What do these changes do?

Do not add job to _jobs list while waiting for a free slot in the pending queue.

Related issue number

#97, #98

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes
  • [x] Add a new news fragment into the CHANGES folder

pollydrag avatar Nov 01 '19 10:11 pollydrag

Codecov Report

Merging #135 (f56e16c) into master (041945f) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head f56e16c differs from pull request most recent head 91cb325. Consider uploading reports for the commit 91cb325 to get more accurate results

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          231       246   +15     
=========================================
+ Hits           231       246   +15     
Impacted Files Coverage Δ
aiojobs/_scheduler.py 100.00% <100.00%> (ø)
aiojobs/_job.py 100.00% <0.00%> (ø)
aiojobs/aiohttp.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 01 '19 10:11 codecov[bot]

We might be hitting this in production.

Tinche avatar Dec 15 '19 01:12 Tinche

Is there any plans to merge this PR?

oleynikandrey avatar Jun 18 '20 20:06 oleynikandrey

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 16 '20 10:11 CLAassistant

@pollydrag Any updates?

NotoriousRebel avatar Sep 21 '21 03:09 NotoriousRebel

@asvetlov Can you review this, please?

pollydrag avatar Sep 21 '21 16:09 pollydrag

Hi guys, does anybody have a maintained fork of this repository? It may be great to have a maintained fork.

simon-liebehenschel avatar Apr 19 '22 09:04 simon-liebehenschel

@hlecnt and other people:

As long as the package is abandoned, I will maintain a fork to help everyone keep using this package without critical bugs. This fix is available:

pip install aiojobs-fork==1.0.2

simon-liebehenschel avatar Aug 27 '22 18:08 simon-liebehenschel