aiohttp
aiohttp copied to clipboard
Fixes read_timeout on WS connection not respecting ws_connect's timeouts
Added read_timeout
property to ResponseHandler
to allow override
After WS(S) connection is established, adjust conn.proto.read_timeout
to
be the largest of the read_timeout
and the ws_connect
's
timeout.ws_receive
with None
treated as 'no timeout', i.e. the maximum.
fixes #8444
Checklist
- [X] I think the code is well written
- [X] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [X] If you provide code modification, please add yourself to
CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- [X] Add a new news fragment into the
CHANGES/
folder-
name it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
) -
if you don't have an issue number, change it to the pull request number after creating the PR
-
.bugfix
: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. -
.feature
: A new behavior, public APIs. That sort of stuff. -
.deprecation
: A declaration of future API removals and breaking changes in behavior. -
.breaking
: When something public is removed in a breaking way. Could be deprecated in an earlier release. -
.doc
: Notable updates to the documentation structure or build process. -
.packaging
: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. -
.contrib
: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. -
.misc
: Changes that are hard to assign to any of the above categories.
-
-
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.
Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
-