aiohttp
aiohttp copied to clipboard
aiodns can probably be enabled on windows, now that it ships with c-ares already built
Is your feature request related to a problem?
The aiodns library from the [speedup] bundle is currently disabled on Windows per this line .
However, aiodns currently ships with pycares, which bundles a binary of c-ares by default. I was just now able to install it on Win10 with pip.
Describe the solution you'd like
It seems there's no need to exclude Windows from the aiodns speedup. Looks like changing https://github.com/aio-libs/aiohttp/blob/master/setup.cfg#L64 would be sufficient, but I'm by no means experienced, so I'd rather not mess with the repo myself.
Describe alternatives you've considered
There seems to be some requests to get rid of aiodns entirely in favour of pydns, but maybe till then we can use it like this?
Related component
Client
Additional context
No response
Code of Conduct
- [X] I agree to follow the aio-libs Code of Conduct
You can still use it, the dependency helper (speedups extra) doesn't influence anything short of what's pulled in on install. If it's present in the env, it'll be used.
Should be an easy fix then, especially if it's strongly recommended for performance reason.
You could make a PR to see how our CI likes it.