[3.9] Fix cookie handling (#6638)

[galaxyfeeder]

• Fix cookie handling

• Fix cookie handling

• [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

• Update aiohttp/cookiejar.py

Co-authored-by: Sam Bull [email protected]

Co-authored-by: Bruno Cabral [email protected] Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sam Bull [email protected] (cherry picked from commit 916b3eecda825cd42415b6f8821c035647baf890)

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

• [ ] I think the code is well written
• [ ] Unit tests for the changes exist
• [ ] Documentation reflects the changes
• [ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [ ] Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[galaxyfeeder]

@Dreamsorcerer @webknjaz I don't think I should correct the lint error that there is in 3.9 branch for merging this as it was already present on the branch before this PR, but let me know if you think different.

[Dreamsorcerer]

@Dreamsorcerer @webknjaz I don't think I should correct the lint error that there is in 3.9 branch for merging this as it was already present on the branch before this PR, but let me know if you think different.

I've done it separately. But, I now remember there is another issue on 3.9 branch which causes all the tests to fail. We'll need to sort that out separately, then we can merge this (and probably some other pending backports).

[Dreamsorcerer]

If you could merge latest 3.9 branch, so tests get passing again, that would be great.

[codecov[bot]]

Codecov Report

Merging #6891 (f46ed55) into 3.9 (9f8d48d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.9    #6891   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         103      103           
  Lines       30170    30183   +13     
  Branches     3738     3738           
=======================================
+ Hits        29360    29373   +13     
  Misses        617      617           
  Partials      193      193           

Flag	Coverage Δ
CI-GHA	97.21% <100.00%> (+<0.01%)	:arrow_up:
OS-Linux	96.86% <100.00%> (+<0.01%)	:arrow_up:
OS-Windows	94.37% <100.00%> (+<0.01%)	:arrow_up:
OS-macOS	96.48% <100.00%> (+<0.01%)	:arrow_up:
Py-3.10.6	?
Py-3.10.7	96.97% <100.00%> (+0.26%)	:arrow_up:
Py-3.11.0-rc.2	96.33% <100.00%> (-0.05%)	:arrow_down:
Py-3.7.14	96.67% <100.00%> (+<0.01%)	:arrow_up:
Py-3.7.9	94.22% <100.00%> (+<0.01%)	:arrow_up:
Py-3.8.10	94.14% <100.00%> (-0.01%)	:arrow_down:
Py-3.8.13	?
Py-3.8.14	96.63% <100.00%> (+0.17%)	:arrow_up:
Py-3.9.13	94.15% <100.00%> (-2.78%)	:arrow_down:
Py-3.9.14	96.59% <100.00%> (+0.22%)	:arrow_up:
Py-pypy7.3.9	96.22% <100.00%> (+<0.01%)	:arrow_up:
VM-macos	96.48% <100.00%> (+<0.01%)	:arrow_up:
VM-ubuntu	96.86% <100.00%> (+<0.01%)	:arrow_up:
VM-windows	94.37% <100.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/cookiejar.py	98.83% <100.00%> (ø)
tests/test_cookiejar.py	99.07% <100.00%> (+0.03%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more