aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

Update third_party.rst

Open sjyothi54 opened this issue 2 years ago • 1 comments

What do these changes do?

Hi Team We have many users on our platform who are using AIOHTTP and would like to instrument it. We’d love to provide a smooth experience for AIOHTTP users who need to use commercial monitoring solutions. Please see our documentation here.

Please consider adding a link for your direct users to provide an option for New Relic. We propose the content submitted in this PR.

Are there changes in behavior for the user?

Related issue number

Checklist

  • [ ] I think the code is well written
  • [ ] Unit tests for the changes exist
  • [ ] Documentation reflects the changes
  • [ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [ ] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

sjyothi54 avatar Aug 10 '22 09:08 sjyothi54

Codecov Report

Merging #6879 (1f92520) into master (a91a8ae) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6879   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         106      106           
  Lines       31455    31455           
  Branches     3939     3939           
=======================================
  Hits        30609    30609           
  Misses        643      643           
  Partials      203      203           
Flag Coverage Δ
CI-GHA 97.21% <ø> (ø)
OS-Linux 96.88% <ø> (ø)
OS-Windows 95.34% <ø> (ø)
OS-macOS 96.47% <ø> (ø)
Py-3.10.11 96.98% <ø> (ø)
Py-3.11.0 96.42% <ø> (-0.01%) :arrow_down:
Py-3.7.16 96.70% <ø> (ø)
Py-3.7.9 95.21% <ø> (ø)
Py-3.8.10 95.13% <ø> (ø)
Py-3.8.16 96.61% <ø> (ø)
Py-3.9.13 95.13% <ø> (ø)
Py-3.9.16 96.64% <ø> (ø)
Py-pypy7.3.11 94.12% <ø> (-0.01%) :arrow_down:
VM-macos 96.47% <ø> (ø)
VM-ubuntu 96.88% <ø> (ø)
VM-windows 95.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 10 '22 09:08 codecov[bot]

@sjyothi54 why are your docs using some weird spelling of aiohttp? It's a single word, without whitespaces, lowercase.

webknjaz avatar May 24 '23 11:05 webknjaz

@webknjaz Thank you for your suggestion. We have updated the name to "AIOHTTP" in both the documentation and the Quickstart page. If you have any further recommendations or if there is anything else that needs to be addressed, please let us know. Here are the attached screenshots: Screenshot 2023-05-26 at 7 35 44 AM Screenshot 2023-05-26 at 7 51 00 AM

sjyothi54 avatar May 26 '23 02:05 sjyothi54

We have updated the name to "AIOHTTP" in both the documentation and the Quickstart page. If you have any further recommendations or if there is anything else that needs to be addressed, please let us know.

But why uppercase? It should be lowercase.

webknjaz avatar May 26 '23 02:05 webknjaz

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/21f0dc2b355a15698ec32592912ee84e6df2148f/pr-6879

Backported as https://github.com/aio-libs/aiohttp/pull/7303

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 27 '23 11:05 patchback[bot]