aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

Use PathLike

Open Dreamsorcerer opened this issue 3 years ago • 1 comments
trafficstars

Dreamsorcerer avatar Aug 08 '22 17:08 Dreamsorcerer

This pull request introduces 3 alerts when merging 0efe15d149a1062077b1fc55b88ca76a7983fc74 into 799dc8742e2cc0b5a819ba454878d09bbfe2df82 - view on LGTM.com

new alerts:

  • 3 for Unused import

lgtm-com[bot] avatar Aug 08 '22 18:08 lgtm-com[bot]

This pull request introduces 1 alert when merging c3d53a252478a3221fda808edf431e0379f5452b into c0a76660f23990f51169e853c8960ba446eccf80 - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 20 '22 01:11 lgtm-com[bot]

Codecov Report

Merging #6876 (d923b0a) into master (c0a7666) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6876      +/-   ##
==========================================
- Coverage   97.50%   97.50%   -0.01%     
==========================================
  Files         103      103              
  Lines       29999    30043      +44     
  Branches     3651     3659       +8     
==========================================
+ Hits        29252    29294      +42     
- Misses        567      568       +1     
- Partials      180      181       +1     
Flag Coverage Δ
CI-GHA 97.41% <100.00%> (-0.01%) :arrow_down:
OS-Linux 97.04% <100.00%> (-0.02%) :arrow_down:
OS-Windows 95.34% <100.00%> (-0.06%) :arrow_down:
OS-macOS 96.63% <100.00%> (-0.06%) :arrow_down:
Py-3.10.8 97.16% <100.00%> (-0.07%) :arrow_down:
Py-3.11.0 96.55% <100.00%> (-0.01%) :arrow_down:
Py-3.7.15 96.88% <100.00%> (-0.01%) :arrow_down:
Py-3.7.9 95.23% <100.00%> (-0.06%) :arrow_down:
Py-3.8.10 95.13% <100.00%> (-0.06%) :arrow_down:
Py-3.8.14 96.77% <100.00%> (-0.01%) :arrow_down:
Py-3.9.13 95.12% <100.00%> (-0.06%) :arrow_down:
Py-3.9.14 96.52% <100.00%> (-0.06%) :arrow_down:
Py-3.9.15 96.75% <100.00%> (-0.01%) :arrow_down:
Py-pypy7.3.9 96.38% <100.00%> (-0.06%) :arrow_down:
VM-macos 96.63% <100.00%> (-0.06%) :arrow_down:
VM-ubuntu 97.04% <100.00%> (-0.02%) :arrow_down:
VM-windows 95.34% <100.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 99.18% <100.00%> (+<0.01%) :arrow_up:
aiohttp/web_fileresponse.py 99.29% <100.00%> (+1.37%) :arrow_up:
aiohttp/web_runner.py 97.75% <100.00%> (ø)
aiohttp/web_urldispatcher.py 97.82% <100.00%> (-0.01%) :arrow_down:
tests/test_web_sendfile.py 100.00% <100.00%> (ø)
aiohttp/__init__.py 92.85% <0.00%> (-7.15%) :arrow_down:
aiohttp/http.py 100.00% <0.00%> (ø)
aiohttp/connector.py 94.62% <0.00%> (ø)
tests/test_streams.py 100.00% <0.00%> (ø)
tests/test_multipart.py 100.00% <0.00%> (ø)
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 28 '22 22:11 codecov[bot]

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b571bb966a632b81ce0ea5751a3a0c56f219edcf on top of patchback/backports/3.9/b571bb966a632b81ce0ea5751a3a0c56f219edcf/pr-6876

Backporting merged PR #6876 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.9/b571bb966a632b81ce0ea5751a3a0c56f219edcf/pr-6876 upstream/3.9
    
  4. Now, cherry-pick PR #6876 contents into that branch:
    $ git cherry-pick -x b571bb966a632b81ce0ea5751a3a0c56f219edcf
    
    If it'll yell at you with something like fatal: Commit b571bb966a632b81ce0ea5751a3a0c56f219edcf is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x b571bb966a632b81ce0ea5751a3a0c56f219edcf
    
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #6876 as close to the original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.9/b571bb966a632b81ce0ea5751a3a0c56f219edcf/pr-6876
    
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Nov 29 '22 18:11 patchback[bot]