aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

Fix aiohttp client redirection bug with complex URLs

Open rgeronimi opened this issue 5 years ago • 3 comments

What do these changes do?

Fix https://github.com/aio-libs/aiohttp/issues/5319

Are there changes in behavior for the user?

No if their code was correct, i.e. if they didn't use buggy URLs during redirects (that were transparently corrected by yarl). If they did use buggy URLs, this was a bug on their side, that was kept hidden thanks to yarl's reencoding of the URL. This pull request will make these bugs visible. This is an exotic case that maybe does not exist in practice, but in theory this is possible.

Related issue number

https://github.com/aio-libs/aiohttp/issues/5319

Checklist

  • [X] I think the code is well written
  • [ ] Unit tests for the changes exist
  • [ ] Documentation reflects the changes
  • [X] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [X] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

rgeronimi avatar Dec 08 '20 16:12 rgeronimi

See comment in https://github.com/docker/buildx/issues/415

rgeronimi avatar Dec 08 '20 18:12 rgeronimi

See comment in docker/buildx#415

Any specific comment? I don't see anything related there.

webknjaz avatar Jul 12 '22 21:07 webknjaz

I'm turning this into draft since it failes the tests.

webknjaz avatar Sep 20 '22 13:09 webknjaz

Closing as abandoned.

webknjaz avatar Jan 29 '24 01:01 webknjaz