aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

`proxy_headers_hash` appears unused

Open dimaqq opened this issue 6 years ago • 2 comments

Looks like ConnectionKey.proxy_headers_hash is always None is never used:

Screenshot 2020-01-17 at 14 46 36

dimaqq avatar Jan 17 '20 05:01 dimaqq

Yes, you are right. We can drop it I guess.

asvetlov avatar Jan 24 '20 16:01 asvetlov

Isn't it used right here? https://github.com/aio-libs/aiohttp/blob/faa15fd7d1bea808a64f979c1a7ace8340d68d61/aiohttp/client_reqrep.py#L315

Dreamsorcerer avatar Aug 22 '24 19:08 Dreamsorcerer

I think this was intended to avoid having to calc the hash every time

bdraco avatar Sep 22 '24 23:09 bdraco

reguardless, it is used

bdraco avatar Sep 22 '24 23:09 bdraco

If it’s used now, that’s great!

dimaqq avatar Sep 23 '24 01:09 dimaqq

It was used when you opened the issue, that's why I questioned it. Here's a link to the same code at the time you opened the issue: https://github.com/aio-libs/aiohttp/blob/95e548c31efe1f53cc0a5eeb919fa8d9e666f4d9/aiohttp/client_reqrep.py#L265

Dreamsorcerer avatar Sep 23 '24 01:09 Dreamsorcerer