aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

Added Unofficial Tabdeal API to Built with aiohttp page

Open MohsenHNSJ opened this issue 6 months ago • 2 comments

What do these changes do?

Adds Unofficial Tabdeal API package to Built with aiohttp documentation page.

Are there changes in behavior for the user?

No, only added a line in documentation.

Is it a substantial burden for the maintainers to support this?

No. The project is maintained by me and as I also use it for my own purposes, it will be maintained for the foreseeable future.

Related issue number

This is not related to any issues.

Checklist

  • [x] I think the code is well written
  • [ ] Unit tests for the changes exist
  • [x] Documentation reflects the changes
  • [ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [ ] Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking changes in behavior.
      • .breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build process.
      • .packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment.
      • .misc: Changes that are hard to assign to any of the above categories.
    • Make sure to use full sentences with correct case and punctuation, for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.
      

      Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.

MohsenHNSJ avatar May 25 '25 09:05 MohsenHNSJ

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.76%. Comparing base (3a2a9b2) to head (3593cc2). :warning: Report is 512 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11009      +/-   ##
==========================================
- Coverage   98.82%   98.76%   -0.07%     
==========================================
  Files         129      129              
  Lines       41505    43377    +1872     
  Branches     2234     2323      +89     
==========================================
+ Hits        41019    42840    +1821     
- Misses        337      383      +46     
- Partials      149      154       +5     
Flag Coverage Δ
CI-GHA 98.64% <ø> (-0.07%) :arrow_down:
OS-Linux 98.38% <ø> (-0.05%) :arrow_down:
OS-Windows 96.81% <ø> (+0.10%) :arrow_up:
OS-macOS 97.68% <ø> (+0.06%) :arrow_up:
Py-3.10.11 97.32% <ø> (-0.08%) :arrow_down:
Py-3.10.17 ?
Py-3.11.12 ?
Py-3.11.13 97.91% <ø> (?)
Py-3.11.9 97.53% <ø> (-0.03%) :arrow_down:
Py-3.12.10 97.62% <ø> (-0.84%) :arrow_down:
Py-3.12.11 98.02% <ø> (?)
Py-3.13.3 98.28% <ø> (-0.17%) :arrow_down:
Py-3.9.13 97.22% <ø> (-0.06%) :arrow_down:
Py-3.9.22 ?
Py-3.9.23 97.61% <ø> (?)
Py-pypy7.3.16 86.25% <ø> (-7.15%) :arrow_down:
VM-macos 97.68% <ø> (+0.06%) :arrow_up:
VM-ubuntu 98.38% <ø> (-0.05%) :arrow_down:
VM-windows 96.81% <ø> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 25 '25 09:05 codecov[bot]

CodSpeed Performance Report

Merging #11009 will not alter performance

Comparing MohsenHNSJ:patch-1 (3593cc2) with master (cb2860a)

Summary

✅ 59 untouched benchmarks

codspeed-hq[bot] avatar May 25 '25 09:05 codspeed-hq[bot]

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d1a410a49ca6353d5efb168cfb22f0309a2d89b2 on top of patchback/backports/3.13/d1a410a49ca6353d5efb168cfb22f0309a2d89b2/pr-11009

Backporting merged PR #11009 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/d1a410a49ca6353d5efb168cfb22f0309a2d89b2/pr-11009 upstream/3.13
    
  4. Now, cherry-pick PR #11009 contents into that branch:
    $ git cherry-pick -x d1a410a49ca6353d5efb168cfb22f0309a2d89b2
    
    If it'll yell at you with something like fatal: Commit d1a410a49ca6353d5efb168cfb22f0309a2d89b2 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x d1a410a49ca6353d5efb168cfb22f0309a2d89b2
    
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #11009 as close to the original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/d1a410a49ca6353d5efb168cfb22f0309a2d89b2/pr-11009
    
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 14 '25 22:07 patchback[bot]