aiohttp-sse icon indicating copy to clipboard operation
aiohttp-sse copied to clipboard

Add EventSourceResponse.last_event_id

Open decaz opened this issue 6 years ago • 2 comments

I think it would be useful to add last_event_id property to the EventSourceResponse class from the example: https://github.com/aio-libs/aiohttp-sse/blob/aca7808960635ff7511ff46002b7f83168f6952c/examples/graceful_shutdown.py#L14-L16

Also there is a bug at that example (sse_response doesn't accept response_cls parameter): https://github.com/aio-libs/aiohttp-sse/blob/aca7808960635ff7511ff46002b7f83168f6952c/examples/graceful_shutdown.py#L63

decaz avatar Mar 13 '19 14:03 decaz

Would you like to create PR with a fix?

jettify avatar Aug 08 '19 02:08 jettify

The fix is already in master. Somebody mighty needs to release 2.2.0. Until then as a "workaround" I directly install from github instead of PyPI

tommmlij avatar Sep 16 '20 17:09 tommmlij