aiohttp-devtools icon indicating copy to clipboard operation
aiohttp-devtools copied to clipboard

Published 20 hours ago • verified publisher icon aio-libs

Features Request: Add HTTPS Support

Open jamesward opened this issue 5 years ago • 3 comments

I'm working on an app that must run on https even on localhost (the SSO identity provider requires it). So it'd be great to have HTTPS support.

jamesward avatar Oct 01 '18 21:10 jamesward

+1 when I run the app over HTTPS, I get a mixed content warning.

Mixed Content: The page at 'https://xxxxxxxxx' was loaded over HTTPS, but requested an insecure script 'http://xxxxxx:8001/livereload.js'. This request has been blocked; the content must be served over HTTPS.

pcgeek86 avatar Jan 07 '20 04:01 pcgeek86

I doubt I'll look at this, but if someone wants to create a PR to support the feature, then we can add it.

Dreamsorcerer avatar Dec 31 '21 16:12 Dreamsorcerer

Just thinking this through, if anyone wants to work on it, we are just calling run_app() at https://github.com/aio-libs/aiohttp-devtools/blob/master/aiohttp_devtools/cli.py#L86

It appears this can be configured with an ssl_context parameter: https://docs.aiohttp.org/en/stable/web_reference.html?highlight=run_app#aiohttp.web.run_app

So, probably an easy task if anyone wants to give it a go.

Dreamsorcerer avatar Dec 31 '21 17:12 Dreamsorcerer