add new datetime parsing format for client to support windows FTP server list output
Description:-
This PR enhances the parse_list_line_windows method to support multiple date/time formats when parsing Microsoft Windows dir command output. Previously, only one specific date/time format was supported. The following improvements were made:
Changes:
-
Added support for two date/time formats: "%m/%d/%Y %I:%M %p" (e.g., 12/18/2024 04:40 PM) "%m-%d-%y %I:%M%p" (e.g., 12-18-24 04:40PM)
-
Introduced a loop to try each format and parse the date/time correctly.
-
Raised a ValueError if none of the formats match, ensuring robust error handling.
Why: Windows FTP servers may use different date/time formats depending on system configurations and locale settings. Supporting multiple formats improves compatibility and reduces parsing failures.
Codecov Report
Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 98.68%. Comparing base (
8c774d8) to head (48ed29d).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/aioftp/client.py | 70.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 98.83% 98.68% -0.16%
==========================================
Files 6 6
Lines 1896 1904 +8
==========================================
+ Hits 1874 1879 +5
- Misses 22 25 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry for the late response. I have addressed all the comments and made the necessary updates.
lint check fails, fix your code according linters, use pre-commit run -a before commit your code