aiodocker icon indicating copy to clipboard operation
aiodocker copied to clipboard

get_archive puts the file in memory

Open AnthonyDeroche opened this issue 4 years ago • 1 comments

Long story short

When calling get_archive in containers.py, could you confirm that the whole file is stored in memory ? If so with a large file, the machine could run out of memory.

What do you suggest to me if I want to get a stream to avoid storing the whole file in memory ?

Your environment

aiodocker 0.19.1 python 3.8.6 Linux

AnthonyDeroche avatar Jan 13 '21 14:01 AnthonyDeroche

Correct, the archive is stored in memory. We should support an alternative API for streaming archive's data probably, PR is welcome.

asvetlov avatar Jul 21 '21 15:07 asvetlov