aiocache icon indicating copy to clipboard operation
aiocache copied to clipboard

New release?

Open zware opened this issue 3 years ago • 6 comments

There are a few useful changes that are not available in the latest 0.11.1 release, such as #478 (fixing Redis clear with namespace that happens to be empty), #470 (quieter imports), #514 (explicit support for Python 3.9).

I couldn't find documentation of release plans, so I figured I would just ask here :)

Thanks!

zware avatar Apr 01 '21 16:04 zware

Also interested to know about this plan. We are having to fork and use our own master branch for the redis clear fix. Will be very helpful to have a new release. Willing to help in this effort.

amatai avatar Jul 10 '21 18:07 amatai

I don't have time to revive the project right now, but I can review and merge PRs if someone wants to get started.

First task will be to get the CI running again, replacing Travis with Github. Use the configuration from one of our other repos as a reference, e.g.: https://github.com/aio-libs/aiohttp-jinja2/blob/master/.github/workflows/ci.yml

Dreamsorcerer avatar Jan 28 '22 17:01 Dreamsorcerer

@Dreamsorcerer Should the Github CI build upon the tox/Makefile setup, or doesn't matter how it does the job as long as it lints tests and deploys?

Mark90 avatar Mar 06 '22 14:03 Mark90

Doesn't need tox, just use a version matrix like in the other projects.

Dreamsorcerer avatar Mar 06 '22 14:03 Dreamsorcerer

OK, CI is running again (thanks @Mark90).

A few more tasks I'd like to take a look at before making a new release (updating aioredis is the main one, and should definetely happen before release):

  • [x] Update aioredis (#546 needs updating)
  • [x] Resolve remaining test failures/warnings (Some tests are being skipped at the moment, and warnings are being ignored, probably needs aioredis updating first) (#588)
  • [x] Remove old/deprecated mentions of loop
  • [x] Add Python 3.10
  • [x] Add Python 3.11
  • [ ] Mypy (Start by uncommenting check_untyped_defs in .mypy.ini and fixing the errors that appear)
  • [x] Replace MagicMock etc. with create_autospec() (#588)
  • [ ] Maybe use aiojobs for background tasks (We have unmanaged tasks in a couple of places created with asyncio.create_task(), which is bad practice)
  • [x] Replace pytest.KEY (It's a stop-gap measure for a long-deprecated feature).
  • [x] Setup Dependabot with auto-merge like our other repos (e.g. look at aiohttp-jinja2).

If anyone wants to pick up some of these tasks, that would be great.

Dreamsorcerer avatar Mar 15 '22 19:03 Dreamsorcerer

@Dreamsorcerer, could you check 572? It's for the last checkbox :)

citramon avatar May 12 '22 12:05 citramon

so is this project dead?

nikolaevigor avatar Nov 08 '22 18:11 nikolaevigor

Tests are running again, except for #585. If anyone has time to debug that one, that would be great. I'll continue on with the other tasks on the list for now, and start looking at all the open PRs.

Dreamsorcerer avatar Dec 28 '22 01:12 Dreamsorcerer

OK, I think as we sort out typing, aiojobs and other open issues, it looks like there will need to be some significant changes to the design.

So, I'll push a release as soon as we have Python 3.11 sorted. The tests on 3.11 are failing, seemingly with the caches not retrieving values: #618.

Dreamsorcerer avatar Jan 01 '23 23:01 Dreamsorcerer

Right, looks like we've got 3.11 working (thanks @a68366). I'll look at doing a release on Friday.

If there's any more PRs people want merged, now is the time. There are quite a few reasonable looking PRs that people haven't bothered to add tests to. So, if anyone wants to finish up any of those, that'd be great.

Dreamsorcerer avatar Jan 02 '23 15:01 Dreamsorcerer

OK, finally out.

If anyone wants to contribute to the next major release, I've tagged several things to do under the 1.0 milestone which are likely to result in backwards-incompatible changes. https://github.com/aio-libs/aiocache/milestone/8

Dreamsorcerer avatar Jan 13 '23 21:01 Dreamsorcerer

@Dreamsorcerer Thank you for driving all these updates and getting them released.

padraic-shafer avatar Jan 13 '23 21:01 padraic-shafer