aiocache icon indicating copy to clipboard operation
aiocache copied to clipboard

Typing

Open JeppeKlitgaard opened this issue 4 years ago • 7 comments

Since aiocache only supports modern Python 3 versions, I was wondering if there would be an interesting in having the library be typed?

I wouldn't mind doing the work to get this done, but wanted to get feedback on whether this is something that the maintainers of aiocache would even want.

On that same note, how do people feel about dropping Python 3.5 support now that the release has officially reached end-of-life.

JeppeKlitgaard avatar Oct 08 '20 14:10 JeppeKlitgaard

Hey @JeppeKlitgaard, I don't have anything against adding typing so go for it 👍. Same with dropping 3.5 support, been a while since wanted to do this plus adding support for 3.8 (and 3.9 now) but if you want to give it a try, please do :)

argaen avatar Oct 08 '20 15:10 argaen

Mypy has been configured on the repository, so if anyone wants to start contributing to this, please feel free to make a PR that adds some more annotations.

To work on it, start by uncommenting check_untyped_defs in .mypy.ini and fixing the errors that appear when running mypy. If there are too many errors to start with, you can disable the option in sections of the code initially until it is manageable. e.g.

[mypy-tests.*]
check_untyped_defs = False

Dreamsorcerer avatar Jan 02 '23 00:01 Dreamsorcerer