aiobotocore icon indicating copy to clipboard operation
aiobotocore copied to clipboard

Bump boto* versions

Open Fokko opened this issue 1 year ago • 2 comments

Description of Change

Bumped the boto versions because I would love to use the bearer authentication: https://github.com/boto/botocore/commit/e5e848a3c9c2c94e36c62d930b0dc42b93c29d43

Assumptions

Everything is still compatible

Checklist for All Submissions

  • [x] I have added change info to CHANGES.rst
  • [ ] If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • [ ] Detailed description of issue
    • [ ] Alternative methods considered (if any)
    • [ ] How issue is being resolved
    • [ ] How issue can be reproduced
  • [ ] If this is providing a new feature (can be provided via link to issue with these details):
    • [ ] Detailed description of new feature
    • [ ] Why needed
    • [ ] Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • [x] I have read and followed CONTRIBUTING.rst
  • [x] I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • [x] I have ensured that the awscli/boto3 versions match the updated botocore version

Fokko avatar Sep 09 '22 13:09 Fokko

@thehesiod Sorry for bothering you, would it be possible to get this in?

Fokko avatar Sep 13 '22 18:09 Fokko

yes going to try to get some PRs merged today

thehesiod avatar Sep 19 '22 23:09 thehesiod

@thehesiod do you have some spare cycles to look into this? It looks like some response has changed, but I'm struggling to find where to fix this in the code.

Fokko avatar Oct 17 '22 20:10 Fokko

my apologies for delays, always crazy with kids, both our kids had bdays recently along with big work push

thehesiod avatar Oct 17 '22 21:10 thehesiod

@thehesiod No worries, I know all about it :) Congratulations on the birthdays!

Fokko avatar Oct 17 '22 21:10 Fokko

working on it now! :)

thehesiod avatar Oct 17 '22 21:10 thehesiod

btw tip for next time, you need to do a directory diff across the two versions and apply any changes to methods we've overridden. I'm having to do it myself again

thehesiod avatar Oct 17 '22 21:10 thehesiod

here some work: https://github.com/aio-libs/aiobotocore/pull/974 unfortunately it seems like they've added a new async path for refreshing tokens that we'll need to override :(. If you'd like to help mind researching that part?

thehesiod avatar Oct 17 '22 22:10 thehesiod

I don't have sufficient knowledge of boto to fix this.

Fokko avatar Nov 01 '22 15:11 Fokko

ok will continue asap

thehesiod avatar Nov 07 '22 21:11 thehesiod

Are there any plans for the near future to bump boto versions? Since version 2.123.0 (3 weeks ago), new sagemaker SDK releases are no longer compatible with this library because the introduction of sagemaker epxeriment functionality required boto3 >=1.26.28.

lorenzwalthert avatar Jan 05 '23 15:01 lorenzwalthert