aim icon indicating copy to clipboard operation
aim copied to clipboard

Improve error messages when setting run param

Open alberttorosyan opened this issue 4 years ago • 3 comments

Proposed refactoring or deprecation

Output informative messages when run parameter cannot be set (i.e. type is not supported by storage)

Motivation

To give users clear error messages and improve onboarding experience.

Pitch

When setting run parameter of unsupported type I would like to get a precise error describing what was done wrong instead of generic Python exception (NotImplementedError)

Additional context

Example:

from aim import Run
import datetime

run = Run()
run["start"] = datetime.datetime.now()  # raises NotImplementedError

alberttorosyan avatar Nov 05 '21 19:11 alberttorosyan

@SGevorg Please assign me this issue.

karan2801 avatar Apr 28 '22 16:04 karan2801

I was not able to reproduce the above issue using the following code snippet:

import datetime

run = Run()
run["start"] = datetime.datetime.now()

The following stack trace is returned on running the above code snippet: Screenshot 2022-05-04 at 11 57 35 PM

It seems the issue has already been fixed as part of this PR. @alberttorosyan Please let me know if I am missing something here.

karan2801 avatar May 04 '22 18:05 karan2801

I suppose the error message could still be much better as the one in the screenshot is still not informative enough. I suppose @gorarakelyan, @alberttorosyan and @karan2801 could help iterate over the message before this actually gets done )))

SGevorg avatar May 05 '22 16:05 SGevorg