aim icon indicating copy to clipboard operation
aim copied to clipboard

intermittent bug when navigating to Run's list

Open JosephBarkate opened this issue 11 months ago • 1 comments

🐛 Bug

Happens intermittently around runs list view, looks like runsRequestRef.abort() is being called when runsRequestRef is undefined

To reproduce

First load click around runs view quickly

Expected behavior

Should not show this issue

Environment

  • Aim Version (e.g., 3.0.1)
  • Python version 3.10
  • pip version
  • MAC 14.7.2
  • Any other relevant information

A simple null check seems to fix this issue, will make PR if I get go ahead.

runsModelMethods.ts line ~950

> function destroy(): void {
>     if (runsRequestRef?.abort) {
>         runsRequestRef.abort();
>     }
>     liveUpdateInstance?.clear();
>     liveUpdateInstance = null;
>     model.setState({
>         ...model.getState(),
>         selectFormData: {
>             ...model.getState().selectFormData,
>             error: null,
>         },
>     });
> }
Image

JosephBarkate avatar Feb 14 '25 04:02 JosephBarkate

Hey @JosephBarkate! Thanks a lot for opening the issue. It would be very nice if you could open the PR. 🙌

mihran113 avatar Feb 18 '25 12:02 mihran113